File jump in jar #110
Merged
File jump in jar #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements jump-to-DAO and SQL‑file functionality for both binary and source JARs, enabling gutter icons and jump actions in the IDE. Key changes include updating the DAO method lookup in SqlLineMakerProvider and PsiDaoMethod to handle JAR-contained files, enhancing DAO resolution in DaoMethodUtil for both module and JAR sources, and adding new utilities for JAR file search and file type checks.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/main/kotlin/org/domaframework/doma/intellij/gutter/sql/SqlLineMakerProvider.kt | Updates the method call to include the DAO file context when looking up DAO methods. |
| src/main/kotlin/org/domaframework/doma/intellij/extension/expr/SqlElExtensions.kt | Removes an unused import. |
| src/main/kotlin/org/domaframework/doma/intellij/common/psi/PsiDaoMethod.kt | Enhances daoFile resolution and adds jar path handling for SQL file path determination. |
| src/main/kotlin/org/domaframework/doma/intellij/common/dao/DaoMethodUtil.kt | Refactors findDaoMethod to accept an optional DAO file and introduces getDaoClassName for class name extraction. |
| src/main/kotlin/org/domaframework/doma/intellij/common/JarFileSearch.kt | Introduces utility functions to locate the JAR root and resolve file paths within JARs. |
| src/main/kotlin/org/domaframework/doma/intellij/common/FileTypeCheck.kt | Adds support for “CLASS” file types in both the file extension mapping and file type checks. |
Comments suppressed due to low confidence (1)
src/main/kotlin/org/domaframework/doma/intellij/common/dao/DaoMethodUtil.kt:115
- [nitpick] Consider defining a constant for the literal "dao/" used in getDaoClassName to make the directory structure assumption explicit and improve maintainability.
private fun getDaoClassName(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added jump-to-DAO and SQL‑file functionality within JARs.
Enabled gutter icons and jump actions in both the binary JAR and its corresponding source JAR.
(The source JAR must be linked to the binary JAR.)